refactor: extraire getAlias dans son propre module et le sécuriser

lib/utils/__tests__/get-alias.test.js

@@ -0,0 +1,26 @@
+import {describe, it, expect} from 'vitest'
+import {getAlias} from '../get-alias'
+
+describe('getAlias', () => {
+  it('retourne une chaîne vide sans planter quand artistes est undefined', () => {
+    expect(getAlias(undefined)).toBe('')
+  })
+
+  it('retourne une chaîne vide sans planter quand artistes est un tableau vide', () => {
+    expect(getAlias([])).toBe('')
+  })
+
+  it('retourne l\'alias unique quand il n\'y a qu\'un artiste', () => {
+    expect(getAlias([{id: 1, alias: 'Foo'}])).toBe('Foo')
+  })
+
+  it('ignore un id de priorité qui ne correspond à aucun artiste (donnée obsolète)', () => {
+    const artistes = [{id: 1, alias: 'Foo'}, {id: 2, alias: 'Bar'}]
+    expect(getAlias(artistes, '1-99-2')).toBe('Foo et Bar')
+  })
+
+  it('formate plusieurs artistes selon la priorité fournie', () => {
+    const artistes = [{id: 1, alias: 'Foo'}, {id: 2, alias: 'Bar'}]
+    expect(getAlias(artistes, '2-1')).toBe('Bar et Foo')
+  })
+})

lib/utils/format.js

@@ -1,54 +1,2 @@
-import slugify from 'slugify'
-
 export const formatJsonString = stringToFormat =>
   stringToFormat.split('\n').map((string, index) => <div key={index}>{`${string}`}<br /></div>) // eslint-disable-line react/no-array-index-key
-
-export const getAlias = (artistes, priorite = null, enhanced = false) => {
-  if (artistes.length === 1 && !enhanced) {
-    return artistes[0].alias
-  }
-
-  if (artistes.length === 1 && enhanced) {
-    return [{
-      type: 'element',
-      value: artistes[0].alias
-    }]
-  }
-
-  const alias = []
-  const splittedPriority = priorite ? priorite.split('-')
-    .map(p => Number.parseInt(p, 10)) : null
-
-  if (splittedPriority) {
-    for (const element of splittedPriority) {
-      const foundedArtistes = artistes.find(({id}) => id === element)
-      alias.push(foundedArtistes.alias)
-    }
-  } else {
-    for (const artiste of artistes) {
-      alias.push(artiste.alias)
-    }
-  }
-
-  if (enhanced) {
-    const list = new Intl.ListFormat('fr').formatToParts(alias)
-    return list
-  }
-
-  return new Intl.ListFormat('fr').format(alias)
-}
-
-function separateString(inputString) {
-  const regex = /\s*,\s*|\s+et\s+/
-  const strings = inputString.split(regex).map(element => element.trim())
-  return strings
-}
-
-export const getAliasObject = inputString => {
-  const awtis = separateString(inputString)
-
-  return awtis.map(alias => ({
-    alias,
-    slug: slugify(alias, {lower: true, remove: /[*#+~.()'"!:@]/g})
-  }))
-}

lib/utils/get-alias.js

@@ -0,0 +1,55 @@
+import slugify from 'slugify'
+
+export const getAlias = (artistes, priorite = null, enhanced = false) => {
+  const safeArtistes = artistes || []
+
+  if (safeArtistes.length === 1 && !enhanced) {
+    return safeArtistes[0].alias
+  }
+
+  if (safeArtistes.length === 1 && enhanced) {
+    return [{
+      type: 'element',
+      value: safeArtistes[0].alias
+    }]
+  }
+
+  const alias = []
+  const splittedPriority = priorite ? priorite.split('-')
+    .map(p => Number.parseInt(p, 10)) : null
+
+  if (splittedPriority) {
+    for (const element of splittedPriority) {
+      const foundedArtistes = safeArtistes.find(({id}) => id === element)
+      if (foundedArtistes) {
+        alias.push(foundedArtistes.alias)
+      }
+    }
+  } else {
+    for (const artiste of safeArtistes) {
+      alias.push(artiste.alias)
+    }
+  }
+
+  if (enhanced) {
+    const list = new Intl.ListFormat('fr').formatToParts(alias)
+    return list
+  }
+
+  return new Intl.ListFormat('fr').format(alias)
+}
+
+function separateString(inputString) {
+  const regex = /\s*,\s*|\s+et\s+/
+  const strings = inputString.split(regex).map(element => element.trim())
+  return strings
+}
+
+export const getAliasObject = inputString => {
+  const awtis = separateString(inputString)
+
+  return awtis.map(alias => ({
+    alias,
+    slug: slugify(alias, {lower: true, remove: /[*#+~.()'"!:@]/g})
+  }))
+}