chore: activer ESLint sur le backend
Installe eslint, ajoute le script lint, modernise le parser (retrait de babel-eslint obsolète) et applique l'autofix (points-virgules manquants sur l'ensemble du code, conformément à la règle "semi" déjà présente dans .eslintrc mais jamais appliquée faute d'ESLint installé et d'un script pour l'exécuter).
This commit is contained in:
@@ -1,17 +1,17 @@
|
||||
import {describe, it, expect, vi} from 'vitest'
|
||||
import {describe, it, expect, vi} from 'vitest';
|
||||
|
||||
const {default: createController} = await import('../artiste.js')
|
||||
const {default: createController} = await import('../artiste.js');
|
||||
|
||||
function buildStrapi({dbUser, existingArtiste = null}) {
|
||||
const dbQuery = {
|
||||
findOne: vi.fn(async () => existingArtiste)
|
||||
}
|
||||
};
|
||||
const artisteDocuments = {
|
||||
create: vi.fn(async ({data}) => ({id: 42, ...data}))
|
||||
}
|
||||
};
|
||||
const userDocuments = {
|
||||
findOne: vi.fn(async () => dbUser)
|
||||
}
|
||||
};
|
||||
|
||||
const strapi = {
|
||||
contentType: vi.fn(() => ({uid: 'api::artiste.artiste', kind: 'collectionType'})),
|
||||
@@ -19,13 +19,13 @@ function buildStrapi({dbUser, existingArtiste = null}) {
|
||||
query: vi.fn(() => dbQuery)
|
||||
},
|
||||
documents: vi.fn(uid => {
|
||||
if (uid === 'plugin::users-permissions.user') return userDocuments
|
||||
if (uid === 'api::artiste.artiste') return artisteDocuments
|
||||
throw new Error(`unexpected uid: ${uid}`)
|
||||
if (uid === 'plugin::users-permissions.user') return userDocuments;
|
||||
if (uid === 'api::artiste.artiste') return artisteDocuments;
|
||||
throw new Error(`unexpected uid: ${uid}`);
|
||||
})
|
||||
}
|
||||
};
|
||||
|
||||
return {strapi, artisteDocuments}
|
||||
return {strapi, artisteDocuments};
|
||||
}
|
||||
|
||||
function buildCtx(data) {
|
||||
@@ -36,56 +36,56 @@ function buildCtx(data) {
|
||||
},
|
||||
badRequest: vi.fn(),
|
||||
notFound: vi.fn()
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
const dbUser = {id: 1, documentId: 'user-doc-1', username: 'foo', email: 'foo@bar.com'}
|
||||
const dbUser = {id: 1, documentId: 'user-doc-1', username: 'foo', email: 'foo@bar.com'};
|
||||
|
||||
function buildData(overrides = {}) {
|
||||
return {
|
||||
alias: 'Test Artist',
|
||||
user: {...dbUser},
|
||||
...overrides
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
describe('artiste.create', () => {
|
||||
it('crée l\'artiste quand le user existe et que l\'alias est nouveau', async () => {
|
||||
const {strapi, artisteDocuments} = buildStrapi({dbUser})
|
||||
const controller = createController({strapi})
|
||||
const ctx = buildCtx(buildData())
|
||||
const {strapi, artisteDocuments} = buildStrapi({dbUser});
|
||||
const controller = createController({strapi});
|
||||
const ctx = buildCtx(buildData());
|
||||
|
||||
await controller.create(ctx)
|
||||
await controller.create(ctx);
|
||||
|
||||
expect(artisteDocuments.create).toHaveBeenCalled()
|
||||
})
|
||||
expect(artisteDocuments.create).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('refuse sans planter quand data.user est absent', async () => {
|
||||
const {strapi} = buildStrapi({dbUser})
|
||||
const controller = createController({strapi})
|
||||
const ctx = buildCtx(buildData({user: undefined}))
|
||||
const {strapi} = buildStrapi({dbUser});
|
||||
const controller = createController({strapi});
|
||||
const ctx = buildCtx(buildData({user: undefined}));
|
||||
|
||||
await controller.create(ctx)
|
||||
await controller.create(ctx);
|
||||
|
||||
expect(ctx.badRequest).toHaveBeenCalled()
|
||||
expect(strapi.documents).not.toHaveBeenCalled()
|
||||
})
|
||||
expect(ctx.badRequest).toHaveBeenCalled();
|
||||
expect(strapi.documents).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('ignore les champs non autorisés du payload (mass assignment)', async () => {
|
||||
const {strapi, artisteDocuments} = buildStrapi({dbUser})
|
||||
const controller = createController({strapi})
|
||||
const {strapi, artisteDocuments} = buildStrapi({dbUser});
|
||||
const controller = createController({strapi});
|
||||
const ctx = buildCtx(buildData({
|
||||
isExclusiveArtist: true,
|
||||
userAdmin: {id: 999}
|
||||
}))
|
||||
}));
|
||||
|
||||
await controller.create(ctx)
|
||||
await controller.create(ctx);
|
||||
|
||||
expect(artisteDocuments.create).toHaveBeenCalledWith({
|
||||
data: {
|
||||
alias: 'Test Artist',
|
||||
user: dbUser.id
|
||||
}
|
||||
})
|
||||
})
|
||||
})
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user